On Tue, Dec 01, 2020 at 10:43:30PM +0900, Daniel Palmer wrote: > + np = of_find_compatible_node(NULL, NULL, "mstar,smpctrl"); > + smpctrl = of_iomap(np, 0); > + > + if (!smpctrl) > + return -ENODEV; Wouldn't -ENOMEM be more appropriate here? -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!