Re: [PATCH] NFC: nxp-nci: Make firmware GPIO pin optional

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 30.11.20 12:44, Andy Shevchenko wrote:
On Mon, Nov 30, 2020 at 1:06 PM Schrempf Frieder
<frieder.schrempf@xxxxxxxxxx> wrote:

From: Frieder Schrempf <frieder.schrempf@xxxxxxxxxx>

There are other NXP NCI compatible NFC controllers such as the PN7150
that use an integrated firmware and therefore do not have a GPIO to
select firmware downloading mode. To support these kind of chips,
let's make the firmware GPIO optional.

...

-       gpiod_set_value(phy->gpiod_fw, (mode == NXP_NCI_MODE_FW) ? 1 : 0);
+       if (phy->gpiod_fw)
+               gpiod_set_value(phy->gpiod_fw, (mode == NXP_NCI_MODE_FW) ? 1 : 0);

This change is not needed.

Indeed, thanks!



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux