On Mon, Nov 30, 2020 at 1:06 PM Schrempf Frieder <frieder.schrempf@xxxxxxxxxx> wrote: > > From: Frieder Schrempf <frieder.schrempf@xxxxxxxxxx> > > There are other NXP NCI compatible NFC controllers such as the PN7150 > that use an integrated firmware and therefore do not have a GPIO to > select firmware downloading mode. To support these kind of chips, > let's make the firmware GPIO optional. ... > - gpiod_set_value(phy->gpiod_fw, (mode == NXP_NCI_MODE_FW) ? 1 : 0); > + if (phy->gpiod_fw) > + gpiod_set_value(phy->gpiod_fw, (mode == NXP_NCI_MODE_FW) ? 1 : 0); This change is not needed. -- With Best Regards, Andy Shevchenko
