On Thu, Nov 26, 2020 at 02:15:35AM +0000, Alice Guo wrote: > > > > -----Original Message----- > > From: linux-arm-kernel <linux-arm-kernel-bounces@xxxxxxxxxxxxxxxxxxx> On > > Behalf Of Adam Ford > > Sent: 2020年11月25日 8:45 > > To: Alice Guo <alice.guo@xxxxxxx> > > Cc: devicetree <devicetree@xxxxxxxxxxxxxxx>; Peng Fan <peng.fan@xxxxxxx>; > > Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>; Linux Kernel Mailing List > > <linux-kernel@xxxxxxxxxxxxxxx>; Krzysztof Kozlowski <krzk@xxxxxxxxxx>; Rob > > Herring <robh+dt@xxxxxxxxxx>; dl-linux-imx <linux-imx@xxxxxxx>; Shawn Guo > > <shawnguo@xxxxxxxxxx>; arm-soc <linux-arm-kernel@xxxxxxxxxxxxxxxxxxx> > > Subject: Re: [PATCH v6 4/4] soc: imx8m: change to use platform driver > > > > On Mon, Nov 23, 2020 at 8:04 PM Alice Guo <alice.guo@xxxxxxx> wrote: > > > > > > Directly reading ocotp register depends on that bootloader enables > > > ocotp clk, which is not always effective, so change to use nvmem API. > > > Using nvmem API requires to support driver defer probe and thus change > > > soc-imx8m.c to use platform driver. > > > > > > The other reason is that directly reading ocotp register causes kexec > > > kernel hang because the 1st kernel running will disable unused clks > > > after kernel boots up, and then ocotp clk will be disabled even if > > > bootloader enables it. When kexec kernel, ocotp clk needs to be > > > enabled before reading ocotp registers, and nvmem API with platform > > > driver supported can accomplish this. > > > > > > Signed-off-by: Alice Guo <alice.guo@xxxxxxx> > > > --- > > > > > The patch reads V6, but the change log only shows V2. Can you elaborate on > > what has changed between V2 and V6? > > > > adam > > Hi, > > Sorry. The order of changlog is reversed. Thank Adam for pointing out the problem, and thank Krzysztof for reviewing my patch. > Do I need to resend the patchset with the correct changelog order? No, no need. Best regards, Krzysztof
