On Tue, Nov 24, 2020 at 2:03 PM Ardelean, Alexandru <alexandru.Ardelean@xxxxxxxxxx> wrote: > > > In file included from drivers/spi/spidev.c:26: > > > >> include/uapi/linux/spi/spidev.h:33: warning: "SPI_CPHA" redefined > > > 33 | #define SPI_CPHA 0x01 > > > > Argh! Can we have only one set of flags? > > > > My bad here for not catching this earlier. > > It might be an idea to create a "include/uapi/linux/spi/spi.h" and include this in " include/uapi/linux/spi/spidev.h " > Then the " include/uapi/linux/spi/spi.h " would also be included in " include/linux/spi/spi.h " > We would naturally drop the BIT() macros for the uapi header. uAPI has its own _BIT*() macros. -- With Best Regards, Andy Shevchenko
