On 2020/11/24 17:43, Linus Walleij wrote: > On Sat, Nov 7, 2020 at 9:15 AM Damien Le Moal <damien.lemoal@xxxxxxx> wrote: > >> Add the pinctrl-k210.c pinctrl driver for the Kendryte K210 FPIOA >> (fully programmable IO array) to allow configuring the SoC pin >> functions. The K210 has 48 programmable pins which can take any of 256 >> possible functions. >> >> This patch is inspired from the k210 pinctrl driver for the u-boot >> project and contains many direct contributions from Sean Anderson. >> >> Signed-off-by: Sean Anderson <seanga2@xxxxxxxxx> >> Signed-off-by: Damien Le Moal <damien.lemoal@xxxxxxx> > > The kernel build robot is complaining about this patch so I'm waiting for > a new version. I posted V2 of the series earlier today. That version addresses the build bot error. Note that checkpatch throws a warning on this one for the K210_PIN() macro, but that is in my opinion a checkpatch false positive since similar macro definitions exist in many places in the kernel. > Would also be nice if the maintainer could add some comments? What do you mean ? I do not understand. scripts/get_maintainer.pl indicates that you are the maintainer of the pinctrl drivers subsystem. Do you mean adding an entry to the MAINTAINER file for this driver ? I can do that and put my self as maintainer. Or do you mean you would like a comment from Palmer (riscv arch maintainer) ? > > Yours, > Linus Walleij > -- Damien Le Moal Western Digital Research
