On Fri, Nov 20, 2020 at 01:14:50PM +0100, Adam Ward wrote: > Update bindings for the Dialog Semiconductor DA9121 voltage regulator to add device variants. > > Signed-off-by: Adam Ward <Adam.Ward.opensource@xxxxxxxxxxx> > --- > .../devicetree/bindings/regulator/dlg,da9121.yaml | 177 +++++++++++++++++++-- > MAINTAINERS | 2 + > .../dt-bindings/regulator/dlg,da9121-regulator.h | 22 +++ > 3 files changed, 185 insertions(+), 16 deletions(-) > create mode 100644 include/dt-bindings/regulator/dlg,da9121-regulator.h > > diff --git a/Documentation/devicetree/bindings/regulator/dlg,da9121.yaml b/Documentation/devicetree/bindings/regulator/dlg,da9121.yaml > index cde0d82..1bd177d 100644 > --- a/Documentation/devicetree/bindings/regulator/dlg,da9121.yaml > +++ b/Documentation/devicetree/bindings/regulator/dlg,da9121.yaml > @@ -8,40 +8,185 @@ title: Dialog Semiconductor DA9121 voltage regulator > > maintainers: > - Vincent Whitchurch <vincent.whitchurch@xxxxxxxx> > + - Adam Ward <adam.ward@xxxxxxxxxxxx> I'm quite happy to have myself removed from the list instead. You are in a much better position to maintain the bindings for these chips. > - buck1: > - description: > - Initial data for the Buck1 regulator. > - $ref: "regulator.yaml#" > + interrupt-parent: > + maxItems: 1 > + description: Specifies the reference to the interrupt controller. > + > + interrupts: > + maxItems: 1 > + description: IRQ line information. > + > + dlg,irq-polling-delay-passive: > + maxItems: 1 > + description: | > + Specify the polling period, measured in milliseconds, between interrupt status > + update checks. Range 1000-10000 ms. > + > + regulators: > type: object > + $ref: regulator.yaml# > + description: | > + This node defines the settings for the BUCK. The content of the > + sub-node is defined by the standard binding for regulators; see regulator.yaml. > + The DA9121 regulator is bound using their names listed below > + buck1 - BUCK1 > + buck2 - BUCK2 //DA9122, DA9220, DA9131, DA9132 only This move to a sub-node means that older devicetrees won't work. I assume that's fine since the driver is only in linux-next at the moment, but perhaps it's worth mentioning this in the commit message? > + > + patternProperties: > + "^buck([0-1])$": > + type: object > + $ref: regulator.yaml# > + > + properties: > + regulator-mode: > + maxItems: 1 > + description: Defined in include/dt-bindings/regulator/dlg,da9121-regulator.h > + > + regulator-initial-mode: > + maxItems: 1 > + description: Defined in include/dt-bindings/regulator/dlg,da9121-regulator.h > > -unevaluatedProperties: false I think my s/unevaluatedProperties/additionalProperties/ fix is already in linux-next, so this looks like it needs rebasing.
