On 11/18/20 1:45 PM, Florian Fainelli wrote: > On 11/18/20 5:24 AM, Rafał Miłecki wrote: >> From: Rafał Miłecki <rafal@xxxxxxxxxx> >> >> Broadcom's PMB is reset controller used for disabling and enabling SoC >> devices. >> >> Signed-off-by: Rafał Miłecki <rafal@xxxxxxxxxx> >> --- >> .../devicetree/bindings/reset/brcm,pmb.yaml | 51 +++++++++++++++++++ >> include/dt-bindings/reset/brcm,pmb.h | 9 ++++ >> 2 files changed, 60 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/reset/brcm,pmb.yaml >> create mode 100644 include/dt-bindings/reset/brcm,pmb.h >> >> diff --git a/Documentation/devicetree/bindings/reset/brcm,pmb.yaml b/Documentation/devicetree/bindings/reset/brcm,pmb.yaml >> new file mode 100644 >> index 000000000000..ea78ab629c45 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/reset/brcm,pmb.yaml >> @@ -0,0 +1,51 @@ >> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/reset/brcm,pmb.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Broadcom PMB Master reset controller >> + >> +description: This document describes Broadcom's PMB controller. It supports >> + resetting various types of connected devices (e.g. PCIe, USB, SATA). It >> + requires specifying device address. >> + >> +maintainers: >> + - Rafał Miłecki <rafal@xxxxxxxxxx> >> + >> +properties: >> + compatible: >> + enum: >> + - brcm,bcm4908-pmb # PMB on BCM4908 and compatible SoCs >> + >> + reg: >> + maxItems: 1 >> + >> + big-endian: >> + $ref: /schemas/types.yaml#/definitions/flag >> + description: >> + Flag to use for block working in big endian mode. >> + >> + "#reset-cells": >> + const: 2 > > I believe we would need a description of the #reset-cells property that > indicates what they do. > > Other than that and the build failure below: I don't know how to express constraints on each of the cells, but since they are represented by 8 bits you may want to add mininimum: 0 / maximum: 255 constraints in the YAML binding. -- Florian
