On 11/18/20 5:24 AM, Rafał Miłecki wrote: > From: Rafał Miłecki <rafal@xxxxxxxxxx> > > Broadcom's PMB is reset controller used for disabling and enabling SoC > devices. > > Signed-off-by: Rafał Miłecki <rafal@xxxxxxxxxx> > --- > .../devicetree/bindings/reset/brcm,pmb.yaml | 51 +++++++++++++++++++ > include/dt-bindings/reset/brcm,pmb.h | 9 ++++ > 2 files changed, 60 insertions(+) > create mode 100644 Documentation/devicetree/bindings/reset/brcm,pmb.yaml > create mode 100644 include/dt-bindings/reset/brcm,pmb.h > > diff --git a/Documentation/devicetree/bindings/reset/brcm,pmb.yaml b/Documentation/devicetree/bindings/reset/brcm,pmb.yaml > new file mode 100644 > index 000000000000..ea78ab629c45 > --- /dev/null > +++ b/Documentation/devicetree/bindings/reset/brcm,pmb.yaml > @@ -0,0 +1,51 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/reset/brcm,pmb.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Broadcom PMB Master reset controller > + > +description: This document describes Broadcom's PMB controller. It supports > + resetting various types of connected devices (e.g. PCIe, USB, SATA). It > + requires specifying device address. > + > +maintainers: > + - Rafał Miłecki <rafal@xxxxxxxxxx> > + > +properties: > + compatible: > + enum: > + - brcm,bcm4908-pmb # PMB on BCM4908 and compatible SoCs > + > + reg: > + maxItems: 1 > + > + big-endian: > + $ref: /schemas/types.yaml#/definitions/flag > + description: > + Flag to use for block working in big endian mode. > + > + "#reset-cells": > + const: 2 I believe we would need a description of the #reset-cells property that indicates what they do. Other than that and the build failure below: Reviewed-by: Florian Fainelli <f.fainelli@xxxxxxxxx> > + > +required: > + - compatible > + - reg > + - "#reset-cells" > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/reset/brcm,pmb.h> > + > + pmb: reset-controller@802800e0 { > + compatible = "brcm,bcm4908-pmb"; > + reg = <0x802800e0 0x20>; > + #reset-cells = <2>; > + }; > + > + foo { > + resets = <&pmb BRCM_PMB_USB 17>; > + } You are missing a ';' here which is why the binding example did not build. > diff --git a/include/dt-bindings/reset/brcm,pmb.h b/include/dt-bindings/reset/brcm,pmb.h > new file mode 100644 > index 000000000000..1b724e451de1 > --- /dev/null > +++ b/include/dt-bindings/reset/brcm,pmb.h > @@ -0,0 +1,9 @@ > +/* SPDX-License-Identifier: GPL-2.0-or-later OR MIT */ > + > +#ifndef _DT_BINDINGS_RESET_BRCM_PMB > +#define _DT_BINDINGS_RESET_BRCM_PMB > + > +#define BRCM_PMB_USB 0x01 > +#define BRCM_PMB_PCIE 0x02 > + > +#endif > -- Florian
