On Fri, Nov 13, 2020, 4:26 PM Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote: > On Fri, 13 Nov 2020 at 06:09, Bongsu Jeon <bongsu.jeon@xxxxxxxxxxx> wrote: > > > > > > Add driver for Samsung S3FWRN82 NFC controller. > > S3FWRN82 is using NCI protocol and I2C communication interface. > > > > Signed-off-by: Bongsu Jeon <bongsu.jeon@xxxxxxxxxxx> > > --- > > drivers/nfc/Kconfig | 1 + > > drivers/nfc/Makefile | 1 + > > drivers/nfc/s3fwrn82/Kconfig | 15 ++ > > drivers/nfc/s3fwrn82/Makefile | 10 ++ > > drivers/nfc/s3fwrn82/core.c | 133 +++++++++++++++ > > drivers/nfc/s3fwrn82/i2c.c | 288 ++++++++++++++++++++++++++++++++ > > drivers/nfc/s3fwrn82/s3fwrn82.h | 86 ++++++++++ > > 7 files changed, 534 insertions(+) > > create mode 100644 drivers/nfc/s3fwrn82/Kconfig > > create mode 100644 drivers/nfc/s3fwrn82/Makefile > > create mode 100644 drivers/nfc/s3fwrn82/core.c > > create mode 100644 drivers/nfc/s3fwrn82/i2c.c > > create mode 100644 drivers/nfc/s3fwrn82/s3fwrn82.h > > No, this is a copy of existing s3fwrn5. > > Please do not add drivers which are duplicating existing ones but > instead work on extending them. > > Best regards, > Krzysztof > I understand your explain. Actually I thought that generic name like samsung-nci would be better than samsung's nfc chip name.
