On Sun, 15 Nov 2020 at 01:54, Bongsu Jeon <bs.jeon87@xxxxxxxxx> wrote: > > On Fri, Nov 13, 2020 at 4:26 PM Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote: > > > > On Fri, 13 Nov 2020 at 06:09, Bongsu Jeon <bongsu.jeon@xxxxxxxxxxx> wrote: > > > > > > > > > Add driver for Samsung S3FWRN82 NFC controller. > > > S3FWRN82 is using NCI protocol and I2C communication interface. > > > > > > Signed-off-by: Bongsu Jeon <bongsu.jeon@xxxxxxxxxxx> > > > --- > > > drivers/nfc/Kconfig | 1 + > > > drivers/nfc/Makefile | 1 + > > > drivers/nfc/s3fwrn82/Kconfig | 15 ++ > > > drivers/nfc/s3fwrn82/Makefile | 10 ++ > > > drivers/nfc/s3fwrn82/core.c | 133 +++++++++++++++ > > > drivers/nfc/s3fwrn82/i2c.c | 288 ++++++++++++++++++++++++++++++++ > > > drivers/nfc/s3fwrn82/s3fwrn82.h | 86 ++++++++++ > > > 7 files changed, 534 insertions(+) > > > create mode 100644 drivers/nfc/s3fwrn82/Kconfig > > > create mode 100644 drivers/nfc/s3fwrn82/Makefile > > > create mode 100644 drivers/nfc/s3fwrn82/core.c > > > create mode 100644 drivers/nfc/s3fwrn82/i2c.c > > > create mode 100644 drivers/nfc/s3fwrn82/s3fwrn82.h > > > > No, this is a copy of existing s3fwrn5. > > > > Please do not add drivers which are duplicating existing ones but > > instead work on extending them. > > > > Best regards, > > Krzysztof > > I'm bongsu jeon and working for samsung nfc chip development. > If I extend the code for another nfc chip model, Could I change the > s3fwrn5 directory and Module name? > I think the name would confuse some people if they use the other nfc > chip like s3fwrn82. Hi, Renaming would only make git history trickier to follow. Multiple drivers get extended and not renamed. Anyone configuring the kernel should check through Kconfig description, compatibles or description in bindings, so name of directory does not matter when looking for HW support. Then someone would add different chip support, and you would rename as well? So no, do not rename it. Best regards, Krzysztof
