On Sun, 15 Nov 2020 00:16:48 +0100 Andreas Färber <afaerber@xxxxxxx> wrote: > I do understand the idea. My point was that you added a 4-line comment > about status property further above, but no comments about phy-handle > nor managed properties down here. > > It might also be a good idea to explain in a comment why they are > mutually exclusive (mod-def0, multiplexer). > > Have you done any debugging as to why we can't just leave the sfp node > enabled? Current phylink code will, in such situation, try to connect both phy and sfp. It will try to configure settings from both, depending on when last interrupt came from PHY and when SFP module state changed. It will break. Also if there is another PHY in the SFP module, it won't be able to get connected. It is simpler to leave sfp node disabled and get full support for this configuration into kernel first. > Does it toggle mod-def0-gpios on probe even if no SFP is > physically present on i2c? Maybe it can be simplified over in sfp code? mod-deg0-gpio is not toggled by kernel. It is an input gpio. Its state determines whether sfp module is present.
