Re: [PATCH mvebu-dt v2 2/6] ARM: dts: turris-omnia: add comphy handle to eth2

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 14.11.20 19:32, Marek Behún wrote:
> The eth2 controller on Turris Omnia is connected to SerDes. For SFP to
> be able to switch between 1G ans 2.5G modes the comphy link has to be

Typo "ans" is still present in v2, despite pointed out by Andrew.

> defined.
> 
> Signed-off-by: Marek Behún <kabel@xxxxxxxxxx>
> Fixes: f3a6a9f3704a ("ARM: dts: add description for Armada 38x ...")
> Reviewed-by: Andrew Lunn <andrew@xxxxxxx>
> Cc: Uwe Kleine-König <uwe@xxxxxxxxxxxxxxxxx>
> Cc: Jason Cooper <jason@xxxxxxxxxxxxxx>
> Cc: Gregory CLEMENT <gregory.clement@xxxxxxxxxxx>
> Cc: Andreas Färber <afaerber@xxxxxxx>
> Cc: Rob Herring <robh+dt@xxxxxxxxxx>
> Cc: devicetree@xxxxxxxxxxxxxxx
> ---
>  arch/arm/boot/dts/armada-385-turris-omnia.dts | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/boot/dts/armada-385-turris-omnia.dts b/arch/arm/boot/dts/armada-385-turris-omnia.dts
> index b6bd73d8f2ba..9de26c78ec4c 100644
> --- a/arch/arm/boot/dts/armada-385-turris-omnia.dts
> +++ b/arch/arm/boot/dts/armada-385-turris-omnia.dts
> @@ -129,6 +129,7 @@ &eth2 {
>  	status = "okay";
>  	phy-mode = "sgmii";
>  	phy = <&phy1>;
> +	phys = <&comphy5 2>;
>  	buffer-manager = <&bm>;
>  	bm,pool-long = <2>;
>  	bm,pool-short = <3>;

Property matches what I've come up with,

Reviewed-by: Andreas Färber <afaerber@xxxxxxx>

Thanks,
Andreas

-- 
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer
HRB 36809 (AG Nürnberg)



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux