Re: [PATCH v1 1/2] dt-bindings: leds: Add bindings for intel LGM SOC

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Pavel,

Thanks for your valuable comments, Please see my comments inline.

On 11/5/2020 5:52 PM, Pavel Machek wrote:
On Thu 2020-11-05 17:43:50, Amireddy Mallikarjuna reddy wrote:
Add DT bindings YAML schema for SSO controller driver
of Lightning Mountain(LGM) SoC.

intel -> Intel in the title.
"Lightning Mountain(LGM)" -> 'Lightning Mountain (LGM)"

ok.


+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/leds/leds-lgm.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Intel LGM Soc LED SSO driver
Please spell out LGM and SSO here. Soc -> SoC?
ok.



+          intel,sso-brightness:
+            $ref: /schemas/types.yaml#/definitions/uint32
+            description: brightness level of the LED.
+            minimum: 0
+            maximum: 255
?
In case of using "default-state" property, it is redundant.

+          intel,sso-hw-trigger:
+            type: boolean
+            description: This property indicates Hardware driven/control LED.
Why is this intel specific?
This is not common property, so i used vendor name.
do you suggest only property name without vendor name?

+          intel,sso-hw-blink:
+            type: boolean
+            description: This property indicates Enable LED blink by Hardware.
?
This is not common property, so i used vendor name.
do you suggest only property name without vendor name?

+          intel,sso-blink-rate:
+            $ref: /schemas/types.yaml#/definitions/uint32
+            description: LED HW blink frequency.
?
This is not common property, so i used vendor name.
do you suggest only property name without vendor name?

Best regards,
						Pavel



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux