On Wed, Nov 11, 2020 at 05:28:51PM +0200, Alexandru Ardelean wrote: > On Wed, Nov 11, 2020 at 4:54 PM Guenter Roeck <linux@xxxxxxxxxxxx> wrote: > > > > On 11/11/20 1:12 AM, Alexandru Ardelean wrote: > > > In order to account for any potential overflows that could occur. > > > > > > Signed-off-by: Alexandru Ardelean <alexandru.ardelean@xxxxxxxxxx> > > > > Thinking about it, this can only really happen if the user provides > > excessive values for limit attributes. Those are currently clamped > > later, after the conversion. I think it would be better to modify > > the code to apply a clamp _before_ the conversion as well instead > > of trying to solve the overflow problem with unsigned long long. > > > > Either case, can you send me a register dump for this chip ? > > I asked Mark to help out on this. > Right now I don't have a board around my home-office. > I"m just pulling patches from our own tree to send upstream. > Is there a specific command you have in mind for this i2cdump? > > Is the output of something like this fine: > # i2cdump -r 0x00-0x31 1 0x6f > ? Yes, that should do, assuming the chip is on bus #1, address 0x6f. Thanks, Guenter
