On Thu, 2020-10-29 at 10:34 -0500, Rob Herring wrote: > On Thu, 29 Oct 2020 16:15:10 +0800, Chuanjia Liu wrote: > > Split the PCIe node and add pciecfg node to fix MSI issue. > > > > Signed-off-by: Chuanjia Liu <chuanjia.liu@xxxxxxxxxxxx> > > Acked-by: Ryder Lee <ryder.lee@xxxxxxxxxxxx> > > --- > > .../bindings/pci/mediatek-pcie-cfg.yaml | 39 ++++++ > > .../devicetree/bindings/pci/mediatek-pcie.txt | 129 +++++++++++------- > > 2 files changed, 118 insertions(+), 50 deletions(-) > > create mode 100644 Documentation/devicetree/bindings/pci/mediatek-pcie-cfg.yaml > > > > > My bot found errors running 'make dt_binding_check' on your patch: > > yamllint warnings/errors: > ./Documentation/devicetree/bindings/pci/mediatek-pcie-cfg.yaml:19:7: [warning] wrong indentation: expected 4 but found 6 (indentation) > > dtschema/dtc warnings/errors: > > > See https://patchwork.ozlabs.org/patch/1389940 > > The base for the patch is generally the last rc1. Any dependencies > should be noted. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit. > Thanks for your comment,After install ‘yamllint’ ,I can see this warning ,I will fix it and rebase to 5.10-rc1 in next version.