Re: [EXT] Re: [PATCH v2 1/4] dt-bindings: soc: imx8m: add DT Binding doc for soc unique ID

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 5 Nov 2020 at 13:19, Alice Guo <alice.guo@xxxxxxx> wrote:
>
>
>
> > -----Original Message-----
> > From: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> > Sent: 2020年11月5日 16:26
> > To: Alice Guo <alice.guo@xxxxxxx>
> > Cc: robh+dt@xxxxxxxxxx; shawnguo@xxxxxxxxxx; s.hauer@xxxxxxxxxxxxxx;
> > dl-linux-imx <linux-imx@xxxxxxx>; Peng Fan <peng.fan@xxxxxxx>;
> > devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> > linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> > Subject: [EXT] Re: [PATCH v2 1/4] dt-bindings: soc: imx8m: add DT Binding doc
> > for soc unique ID
> >
> > Caution: EXT Email
> >
> > On Thu, Nov 05, 2020 at 03:26:26PM +0800, Alice Guo wrote:
> > > Add DT Binding doc for the Unique ID of i.MX 8M series.
> > >
> > > Signed-off-by: Alice Guo <alice.guo@xxxxxxx>
> > > ---
> > >  .../devicetree/bindings/arm/fsl.yaml          | 33
> > +++++++++++++++++++
> > >  1 file changed, 33 insertions(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml
> > b/Documentation/devicetree/bindings/arm/fsl.yaml
> > > index e4db0f9ed664..0419f078502b 100644
> > > --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> > > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> > > @@ -901,6 +901,39 @@ properties:
> > >                - fsl,s32v234-evb           # S32V234-EVB2 Customer
> > Evaluation Board
> > >            - const: fsl,s32v234
> > >
> > > +  soc:
> > > +    description:
> > > +      i.MX8M Family SoC must provide a soc node in the root of the device
> > tree,
> > > +      representing the System-on-Chip since these test chips are rather
> > complex.
> > > +    type: object
> > > +    properties:
> > > +      compatible:
> > > +        oneOf:
> > > +          - items:
> > > +              - const: fsl,imx8mm-soc
> > > +              - const: simple-bus
> > > +          - items:
> > > +              - const: fsl,imx8mn-soc
> > > +              - const: simple-bus
> > > +          - items:
> > > +              - const: fsl,imx8mp-soc
> > > +              - const: simple-bus
> > > +          - items:
> > > +              - const: fsl,imx8mq-soc
> > > +              - const: simple-bus
> > > +
> > > +      nvmem-cells:
> > > +        maxItems: 1
> > > +        description: Phandle to the SOC Unique ID provided by a nvmem
> > node
> > > +
> > > +      nvmem-cells-names:
> > > +        const: soc_unique_id
> > > +
> > > +    required:
> > > +      - compatible
> > > +      - nvmem-cells
> > > +      - nvmem-cell-names
> > > +
> >
> > Did you actually test it? I see multiple errors with this patch.
> > fsl-ls1012a-frdm.dt.yaml: /: soc:compatible: ['simple-bus'] is not valid under any
> > of the given schemas
> >
> > Best regards,
> > Krzysztof
>
>
> [Alice Guo] Sorry. I did not see errors what you said. Can you tell me how did you test it?

It was a regular DT check, nothing unusual (make dtbs_check).

Best regards,
Krzysztof




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux