Guennadi Liakhovetski <g.liakhovetski@xxxxxx> writes:
> Hi Robert,
>> +static int of_get_mt9m111_platform_data(struct device *dev,
>> + struct soc_camera_subdev_desc *desc)
>> +{
>> + return 0;
>> +}
>
> Why do you need this function? I would just drop it.
Yeah, drop it sounds good. I wrote it at the beginning to have a clear
structure, and then didn't use it.
>> +static const struct of_device_id mt9m111_of_match[] = {
>> + { .compatible = "micron,mt9m111", },
>
> Not a flaw in this patch, but someone might want to add "micron" to
> Documentation/devicetree/bindings/vendor-prefixes.txt
OK, I'll see what I can submit, it should be doable :)
Cheers.
--
Robert
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
