Re: [PATCH 2/4] dt-bindings: display: Add ABT Y030XX067A panel bindings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





Le dim. 1 nov. 2020 à 13:29, Sam Ravnborg <sam@xxxxxxxxxxxx> a écrit :
On Sun, Nov 01, 2020 at 09:31:48AM +0000, Paul Cercueil wrote:
 The Asia Better Technology (ABT) Y030XX067A panel is a 3.0" 320x480
24-bit IPS LCD panel. Its particularity is that it has non-square pixels
 (as it is 4:3 for a resolution of 320x480), and that it requires odd
lines to be sent as RGB and even lines to be sent as GRB on its 8-bit
 bus.

 Signed-off-by: Paul Cercueil <paul@xxxxxxxxxxxxxxx>
 ---
.../display/panel/abt,y030xx067a.yaml | 54 +++++++++++++++++++
  1 file changed, 54 insertions(+)
create mode 100644 Documentation/devicetree/bindings/display/panel/abt,y030xx067a.yaml

diff --git a/Documentation/devicetree/bindings/display/panel/abt,y030xx067a.yaml b/Documentation/devicetree/bindings/display/panel/abt,y030xx067a.yaml
 new file mode 100644
 index 000000000000..6407e8bf45fa
 --- /dev/null
+++ b/Documentation/devicetree/bindings/display/panel/abt,y030xx067a.yaml
 @@ -0,0 +1,54 @@
 +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
 +%YAML 1.2
 +---
+$id: http://devicetree.org/schemas/display/panel/abt,y030xx067a.yaml#
 +$schema: http://devicetree.org/meta-schemas/core.yaml#
 +
+title: Asia Better Technology 3.0" (320x480 pixels) 24-bit IPS LCD panel
 +
 +description: |
+ The panel must obey the rules for a SPI slave device as specified in
 +  spi/spi-controller.yaml
 +
 +maintainers:
 +  - Paul Cercueil <paul@xxxxxxxxxxxxxxx>
 +
 +allOf:
 +  - $ref: panel-common.yaml#
 +
 +properties:
 +  compatible:
 +    const: abt,y030xx067a
 +
 +  backlight: true
 +  port: true
 +  power-supply: true
 +  reg: true
 +  reset-gpios: true

The binding is missing:
required:
  - compatible
  - reg
  - power-supply
  - reset-gpios
  - ...

additionalProperties: false

So r-b only with these added.

Stupid mistake, sorry about that.

I'll V2.

-Paul


	Sam

 +
 +examples:
 +  - |
 +    #include <dt-bindings/gpio/gpio.h>
 +
 +    spi {
 +        #address-cells = <1>;
 +        #size-cells = <0>;
 +
 +        panel@0 {
 +            compatible = "abt,y030xx067a";
 +            reg = <0>;
 +
 +            spi-max-frequency = <3125000>;
 +
 +            reset-gpios = <&gpe 2 GPIO_ACTIVE_LOW>;
 +
 +            backlight = <&backlight>;
 +            power-supply = <&vcc>;
 +
 +            port {
 +                panel_input: endpoint {
 +                    remote-endpoint = <&panel_output>;
 +                };
 +            };
 +        };
 +    };
 --
 2.28.0





[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux