On Wed, Oct 28, 2020 at 7:01 PM Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> wrote: > On Wed, Oct 28, 2020 at 11:17:10AM +0100, Linus Walleij wrote: > > This converts the Armel MXT touchscreen bindings to YAML > > format and extends them with the following two properties: > > > > - vdda-supply: the optional analog supply voltage > > - vdd-supply: the optional digital supply voltage > > > > I also explained about the reset-gpios property that this > > better be flagged as active high (0) despite actually > > being active low, because all current device trees and > > drivers assume that this is the case and will actively > > drive the line low to assert RESET. > > I wonder if we should fix that in driver and in DTs instead of doing > this cludge... Unfortunately I think there are deployed systems with flashed-in system descriptions depending on this bug in the system description already. I am not thinking about device trees now, but instead ACPI chromebooks, that have their reset line flagged as whatever ACPI or DT-to-ACPI use to indicate an active high line. Despite being active low. I could fix all the in-tree devicetrees and do it the natural way (I have certainly done so before) and then add a quirk if used with ACPI. But it's really risky. I'm afraid of regressions here. Yours, Linus Walleij