Hello Bo, On 19/06/2014 09:07, Bo Shen wrote: > Hi Boris, > > On 06/10/2014 12:04 AM, Boris BREZILLON wrote: >> The HLCDC (High LCD Controller) IP supports 4 different output mode >> (RGB444, RGB565, RGB666 and RGB888) and the pin muxing depends on the >> chosen RGB mode. >> >> Split the pin definition to be able to set the pin config according >> to the >> selected mode. >> >> Signed-off-by: Boris BREZILLON <boris.brezillon@xxxxxxxxxxxxxxxxxx> >> --- >> arch/arm/boot/dts/sama5d3_lcd.dtsi | 127 >> ++++++++++++++++++++++++++++--------- >> 1 file changed, 96 insertions(+), 31 deletions(-) > > On sama5d3xek board, it only works in 24bits output mode. And it > depends on the hardware design. So, I think only keep only one pinctrl > configuration. I'm not describing a specific board design but rather SoC capabilities (this dtsi is SoC related not board related), and the sama5d3 SoC supports 4 different RGB output modes through the RGB connector. If you take a look at patch 7, you'll see that I chose mode 3 (which is RGB888), and given this mode the HLCDC driver (atmel_hlcdc_panel.c) will request the appropriate pin state: atmel,panel = <&panel 3 0>; Best Regards, Boris -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html