On 16:44-20201027, Tomi Valkeinen wrote:
> On 27/10/2020 14:20, Nishanth Menon wrote:
> > On 12:41-20201027, Tomi Valkeinen wrote:
> > [...]
> >
> >> diff --git a/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts
> >> index 52e121155563..5a36d65755ee 100644
> >> --- a/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts
> >> +++ b/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts
> >> @@ -83,6 +83,31 @@ sound0: sound@0 {
> >> "cpb-codec-scki",
> >> "cpb-codec-scki-48000", "cpb-codec-scki-44100";
> >> };
> >> +
> >> + dp_pwr_3v3: fixedregulator-dp-prw {
> >> + compatible = "regulator-fixed";
> >> + regulator-name = "dp-pwr";
> >> + regulator-min-microvolt = <3300000>;
> >> + regulator-max-microvolt = <3300000>;
> >> + gpio = <&exp4 0 0>; /* P0 - DP0_PWR_SW_EN */
> >> + enable-active-high;
> >> +
> >> + /* Always on for now, until dp-connector driver can handle this */
> >> + regulator-always-on;
> >> + };
> >> +
> >> + dp0: connector {
> >> + compatible = "dp-connector";
> >
> > This is not documented? I see the following on checkpatch:
> > +WARNING: DT compatible string "dp-connector" appears un-documented -- check ./Documentation/devicetree/bindings/
> > +#42: FILE: arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts:100:
> > ++ compatible = "dp-connector";
> > + mechanically convert to the typical style using --fix or --fix-inplace.
> > + them to the maintainer, see CHECKPATCH in MAINTAINERS.
>
> Yes, I mentioned this in the cover letter.
>
Aaah thanks. We may need to look at reposting this patch after it hits mainline.
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
