On 27/10/2020 14:20, Nishanth Menon wrote:
> On 12:41-20201027, Tomi Valkeinen wrote:
> [...]
>
>> diff --git a/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts
>> index 52e121155563..5a36d65755ee 100644
>> --- a/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts
>> +++ b/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts
>> @@ -83,6 +83,31 @@ sound0: sound@0 {
>> "cpb-codec-scki",
>> "cpb-codec-scki-48000", "cpb-codec-scki-44100";
>> };
>> +
>> + dp_pwr_3v3: fixedregulator-dp-prw {
>> + compatible = "regulator-fixed";
>> + regulator-name = "dp-pwr";
>> + regulator-min-microvolt = <3300000>;
>> + regulator-max-microvolt = <3300000>;
>> + gpio = <&exp4 0 0>; /* P0 - DP0_PWR_SW_EN */
>> + enable-active-high;
>> +
>> + /* Always on for now, until dp-connector driver can handle this */
>> + regulator-always-on;
>> + };
>> +
>> + dp0: connector {
>> + compatible = "dp-connector";
>
> This is not documented? I see the following on checkpatch:
> +WARNING: DT compatible string "dp-connector" appears un-documented -- check ./Documentation/devicetree/bindings/
> +#42: FILE: arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts:100:
> ++ compatible = "dp-connector";
> + mechanically convert to the typical style using --fix or --fix-inplace.
> + them to the maintainer, see CHECKPATCH in MAINTAINERS.
Yes, I mentioned this in the cover letter.
>
>> + label = "DP0";
>> + type = "full-size";
>> + dp-pwr-supply = <&dp_pwr_3v3>;
>> +
>> + port {
>> + dp_connector_in: endpoint {
>> + remote-endpoint = <&dp0_out>;
>> + };
>> + };
>> + };
>> };
>>
>> &main_pmx0 {
>> @@ -119,6 +144,12 @@ J721E_IOPAD(0x214, PIN_OUTPUT, 4) /* (V4) MCAN1_TX.USB1_DRVVBUS */
>> >;
>> };
>>
>> + dp0_pins_default: dp0_pins_default {
>
> please don't use _ in node names dp0-pins-default perhaps?
Ok.
Tomi
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
