Hi Mark, On Mon, Oct 26, 2020 at 1:13 PM Mark Brown <broonie@xxxxxxxxxx> wrote: > > On Sat, Oct 24, 2020 at 10:03:03PM +0200, Fabien Parent wrote: > > > +Required properties: > > +- compatible: "mediatek,mt6392-regulator" > > This is no longer used by the driver, should be unneeded and therefore > should be removed. It is not used by the driver but it will be used by the MFD driver [0] like this: static const struct mfd_cell mt6392_devs[] = { { [snip] }, { [snip] }, { .name = "mt6392-regulator", .of_compatible = "mediatek,mt6392-regulator" }, { [snip] }, }; [0] drivers/mfd/mt6397-core.c > > > +- mt6392regulator: List of regulators provided by this controller. It is named > > This property doesn't seem to appear anywhere - there's regulators, the > collection of subnodes for each individual regulator which I think is > what is referenced here, but nothing called mt6392regulator. Indeed, I will fix it in the next rev.