Hi, On Fri, Oct 23, 2020 at 4:23 PM Douglas Anderson <dianders@xxxxxxxxxxxx> wrote: > > +examples: > + - | > + #include <dt-bindings/clock/qcom,rpmh.h> > + #include <dt-bindings/gpio/gpio.h> > + #include <dt-bindings/interrupt-controller/irq.h> > + > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + ap_ts: touchscreen@5d { > + compatible = "hid-over-i2c"; You always find one more problem right after you hit send, don't you? Or is that just me? Obviously the above should say compatible = "goodix,gt7375p"; Luckily when I change that "dt_binding_check" still passes. Whew! I won't send a v3 yet and I'll wait for feedback. On the off chance that there are no other problems with this binding and the maintainer wants to land this, I don't have any objections to the maintainer fixing this when the patch lands. -Doug