Hi Rob, On Mon, Oct 19, 2020 at 03:33:59PM -0500, Rob Herring wrote: > On Fri, Oct 16, 2020 at 03:42:04PM +0100, Rui Miguel Silva wrote: > > Hey Jacopo, > > Thanks for the review. > > > > On Thu, Oct 15, 2020 at 04:49:05PM +0200, Jacopo Mondi wrote: > > > Hi Rui, > > > > > > On Wed, Oct 14, 2020 at 03:27:57PM +0100, Rui Miguel Silva wrote: > > > > Convert ov2680 sensor bindings documentation to yaml schema, remove > > > > the textual bindings document and update MAINTAINERS entry. > > > > > > > > Signed-off-by: Rui Miguel Silva <rmfrfs@xxxxxxxxx> > > > > > + clock-names: > > > > + description: > > > > > > I'll never get yaml right, doesn't breaking lines require '|' after > > > the semicolon ? The validator does not complain, so I guess not. > > > > I also had that idea, but looking also to other cases, and also in the > > examlpe-schema where you have both cases, looks like it is not needed. > > '|' will preserve line breaks and formatting. For a single line like > this it doesn't really matter. Though ruamel's round trip will make it a > single line when writing back out. Thanks for the explanation. I'll take the occasion to ask the difference between '|', '|-' and '-|' as I haven't find it documented anywhere. Thanks j > > > > > > > > + Input clock for the sensor. > > Really, you can just drop the description. Doesn't really add anything > specific for this device. > > > > > + items: > > > > + - const: xvclk