[PATCH v3 0/3] Fix checker warnings related to cros-ec binding

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This series fixes a bunch of warnings related to the google,cros-ec
binding, originally reported by Rob Herring.
The patches involve adding missing subnode definitions in the
google,cros-ec binding and the conversion of two existing bindings to
json-schema.

All the related warnings should be fixed after applying the patches,
except for a couple of warnings in the device trees of Qualcomm's
Trogdor and Cheza chromebooks. They define a pdupdate subnode inside
cros-ec that has no binding, the development of drivers and support for
these chromebooks is ongoing and not completely upstreamed yet.

Bindings tested with:

  make dt_binding_check ARCH=<arch> DT_SCHEMA_FILES=...
  make dtbs_check ARCH=<arch> DT_SCHEMA_FILES=...

for <arch> = arm and arm64.

Changes from v2:

  - [Rob] bindings/input/google,cros-ec-keyb.yaml restored to the v1
    version (ie. using unevaluatedProperties: false and referencing
    input/matrix-keymap.yaml)

Regarding the discussion [1] about the addition of a new "codecs"
intermediate node in google,cros-ec.yaml to hold the ec-codec, I decided
to leave it in since I think that should be the proper way to define
it. Currently there's no hardware nor DTs using that device, so when
it's eventually used the sound/soc/codecs/cros_ec_codec.c driver should
be updated to handle the DT structure properly.

  [1] https://www.spinics.net/lists/devicetree/msg382463.html

Cheers,
Ricardo

Ricardo Cañuelo (3):
  dt-bindings: i2c: convert i2c-cros-ec-tunnel to json-schema
  dt-bindings: input: convert cros-ec-keyb to json-schema
  mfd: google,cros-ec: add missing properties

 .../i2c/google,cros-ec-i2c-tunnel.yaml        | 63 +++++++++++++
 .../bindings/i2c/i2c-cros-ec-tunnel.txt       | 39 --------
 .../bindings/input/cros-ec-keyb.txt           | 72 ---------------
 .../bindings/input/google,cros-ec-keyb.yaml   | 92 +++++++++++++++++++
 .../bindings/mfd/google,cros-ec.yaml          | 50 ++++++++++
 .../bindings/sound/google,cros-ec-codec.yaml  | 26 ++++--
 6 files changed, 221 insertions(+), 121 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/i2c/google,cros-ec-i2c-tunnel.yaml
 delete mode 100644 Documentation/devicetree/bindings/i2c/i2c-cros-ec-tunnel.txt
 delete mode 100644 Documentation/devicetree/bindings/input/cros-ec-keyb.txt
 create mode 100644 Documentation/devicetree/bindings/input/google,cros-ec-keyb.yaml

-- 
2.18.0




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux