On Thu, Oct 8, 2020 at 2:45 AM Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > > On Wed, Oct 07, 2020 at 11:15:41PM -0700, Badhri Jagan Sridharan wrote: > > Hi, > > > > Made two changes: > > > > 1. Added "additionalProperties: false" as suggested by Rob Herring in > > https://lore.kernel.org/linux-usb/20201005144618.GA154206@bogus/ > > > > 2. Removed FRS dts binding constants to address Rob Herring's comment in > > https://lore.kernel.org/linux-usb/20201006182940.GA2574941@bogus/ And didn't address my other comments... > That worked better. I've applied the patches that Heikki had reviewed > to my usb-testing branch now. Why is the driver being applied without the binding? Bindings come first. The binding and driver don't even agree on the compatible string (maxim,tcpci vs. maxim,tcpc), neither of which are right. The FRS bindings need to be sorted out too as we have multiple folks proposing bindings for it. I wish someone would review all these TypeC related bindings because I'm getting a continual stream of piecemeal additions with no coordination and I don't have knowledge on TypeC nor bandwidth to review it all. Rob
