On Wed, Oct 7, 2020 at 3:08 PM Adam Ford <aford173@xxxxxxxxx> wrote: > > On Wed, Oct 7, 2020 at 3:03 PM Marek Vasut <marex@xxxxxxx> wrote: > > > > On 10/7/20 9:52 PM, Adam Ford wrote: > > > On Sun, Oct 4, 2020 at 12:53 AM Marek Vasut <marex@xxxxxxx> wrote: > > >> > > >> Add the i.MX8MM BLK_CTL compatible string to the list. > > [...] > > >> --- > > >> Documentation/devicetree/bindings/clock/fsl,imx-blk-ctl.yaml | 1 + > > >> 1 file changed, 1 insertion(+) > > >> > > > > > > Is there a DTSI change part of this patch? I was going to try to test > > > it, but I am not seeing a change to the imx8mm.dtsi, and I am not > > > sure where to put the node. > > > > There are in fact quite a few other pieces you need to have in place, > > this patchset in itself is not particularly useful, it is just infra for > > the LCDIF and MIPI DSIM block control. You might want to wait until they > > all land in next and test that result. > > I have several patches in place, the GPCv2, this block driver, > enabling GPU DT node, I'm also working on the DSIM patch you posted. > I was hoping to test them all together and reply to the various > threads with tested-by. I also want to get my device tree stuff ready > on the beacon boards so when everything lands, I can post DTS updates > to enable the LCDIF, DSI, and the HDMI bridge. > > If you have a repo somewhere that has all these combined, I can just > work on the final layer to enable the device tree plumbing on my > board. I just need the imx8mm.dtsi changes for this, DSIM, and the > LCDIF so I can finish the task. On that note, I also have a i.MX8M Nano board which is similar to my 8MM. If I understood the 8MM clock block driver better, I hope to adapt your changes for the Nano too. Once the GPCv2 driver is accepted, I was also going to look at updating it to support the Nano as well which also has the same DSIM and LCDIF as the 8MM as well and a better GPU than the Mini but lacking the VPU. adam > > adam
