Hello Jonathan, On Sun, Oct 04, 2020 at 03:43:23AM +0200, Jonathan Neuschäfer wrote: > On Fri, Sep 25, 2020 at 07:44:24AM +0200, Uwe Kleine-König wrote: > > > +static struct platform_driver ntxec_rtc_driver = { > > > + .driver = { > > > + .name = "ntxec-rtc", > > > + }, > > > + .probe = ntxec_rtc_probe, > > > > No .remove function? > > I don't think it would serve a purpose in this driver. There are no > device-specific resources to release (no clocks to unprepare, for > example). I had in mind that without a .remove callback the driver cannot detach. but looking in the code (drivers/base/platform.c) this seems wrong. So my concern can be considered void. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ |
Attachment:
signature.asc
Description: PGP signature