Hello Lee, On 06/16/2014 10:44 AM, Lee Jones wrote: >> The MAX77802 PMIC has two 32.768kHz Buffered Clock Outputs with >> Low Jitter Mode. This patch adds support for these two clocks. >> >> Signed-off-by: Javier Martinez Canillas <javier.martinez@xxxxxxxxxxxxxxx> >> --- >> .../devicetree/bindings/clock/maxim,max77802.txt | 40 ++++ >> drivers/clk/Kconfig | 6 + >> drivers/clk/Makefile | 1 + >> drivers/clk/clk-max77802.c | 253 +++++++++++++++++++++ >> drivers/mfd/max77802.c | 3 + >> include/dt-bindings/clock/maxim,max77802.h | 22 ++ >> 6 files changed, 325 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/clock/maxim,max77802.txt >> create mode 100644 drivers/clk/clk-max77802.c >> create mode 100644 include/dt-bindings/clock/maxim,max77802.h > > [...] > >> diff --git a/drivers/mfd/max77802.c b/drivers/mfd/max77802.c >> index 59696dd..33e8023 100644 >> --- a/drivers/mfd/max77802.c >> +++ b/drivers/mfd/max77802.c >> @@ -35,6 +35,9 @@ >> >> static const struct mfd_cell max77802_devs[] = { >> { .name = "max77802-pmic", }, >> +#if defined(CONFIG_COMMON_CLK_MAX77802) > > No, don't do that. If COMMON_CLK_MAX77802 is not defined it just > won't be matched, which is enough to ensure it won't be probed. > Thanks a lot for the explanation. I'll send a v2 patch-set soon which has changes based on the feedback from Mark and Krzysztof. I'll take this point into account as well. >> + { .name = "max77802-clk", }, >> +#endif >> }; > > [...] > Best regards, Javier -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html