On Tue, Sep 22, 2020 at 08:34:03AM +0200, Uwe Kleine-König wrote: > On Mon, Sep 21, 2020 at 01:37:56PM +0300, Andy Shevchenko wrote: > > On Mon, Sep 21, 2020 at 10:44:01AM +0200, Uwe Kleine-König wrote: > > > On Thu, Sep 10, 2020 at 12:27:19AM +0800, vijayakannan.ayyathurai@xxxxxxxxx wrote: > > > > From: Vijayakannan Ayyathurai <vijayakannan.ayyathurai@xxxxxxxxx> > > > > > > > > Add PWM Device Tree bindings documentation for the Intel Keem Bay SoC. > > > > > > > > Signed-off-by: Vineetha G. Jaya Kumaran <vineetha.g.jaya.kumaran@xxxxxxxxx> > > > > Signed-off-by: Vijayakannan Ayyathurai <vijayakannan.ayyathurai@xxxxxxxxx> > > > > Reviewed-by: Rob Herring <robh@xxxxxxxxxx> > > > > Acked-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> > > > > > > nitpick: Your S-o-b should always be last. This way it becomes clear who > > > added the other tags. > > > > I think it should reflect chronological order. If SoB has been given before > > e.g. Ack then SoB should be followed by Ack and not other way around. > > This is how I interpret the rules even though I admit it is not > formalized explicitly. The idea is just what I wrote, when the patch > ends up in git with: > > Signed-off-by: Vineetha G. Jaya Kumaran <vineetha.g.jaya.kumaran@xxxxxxxxx> > Signed-off-by: Vijayakannan Ayyathurai <vijayakannan.ayyathurai@xxxxxxxxx> > Reviewed-by: Rob Herring <robh@xxxxxxxxxx> > Acked-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> > Signed-off-by: Peter Maintainer <p.maintainer@tralala> > > I'd expect that is was Peter M. who added Rob's and my tag, while when > it is > > Signed-off-by: Vineetha G. Jaya Kumaran <vineetha.g.jaya.kumaran@xxxxxxxxx> > Reviewed-by: Rob Herring <robh@xxxxxxxxxx> > Acked-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> > Signed-off-by: Vijayakannan Ayyathurai <vijayakannan.ayyathurai@xxxxxxxxx> > Signed-off-by: Peter Maintainer <p.maintainer@tralala> > > it was Vijayakannan who added them. > > IMHO this makes sense as Vijayakannan modified the commit log and then > it is usual to add the signature at the end. In my eyes this is more > sensible than the date order, but it seems this is subjective. > > I'm aware that most people don't care; and I don't care enough to argue > this case any further. This makes sense. Consider that we are on the same page. Thanks! -- With Best Regards, Andy Shevchenko
