Re: [PATCH v7 2/2] dt-bindings: pwm: keembay: Add bindings for Intel Keem Bay PWM

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Sep 21, 2020 at 10:44:01AM +0200, Uwe Kleine-König wrote:
> On Thu, Sep 10, 2020 at 12:27:19AM +0800, vijayakannan.ayyathurai@xxxxxxxxx wrote:
> > From: Vijayakannan Ayyathurai <vijayakannan.ayyathurai@xxxxxxxxx>
> > 
> > Add PWM Device Tree bindings documentation for the Intel Keem Bay SoC.
> > 
> > Signed-off-by: Vineetha G. Jaya Kumaran <vineetha.g.jaya.kumaran@xxxxxxxxx>
> > Signed-off-by: Vijayakannan Ayyathurai <vijayakannan.ayyathurai@xxxxxxxxx>
> > Reviewed-by: Rob Herring <robh@xxxxxxxxxx>
> > Acked-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
> 
> nitpick: Your S-o-b should always be last. This way it becomes clear who
> added the other tags.

I think it should reflect chronological order. If SoB has been given before
e.g. Ack then SoB should be followed by Ack and not other way around.

But it's my interpretation of the chapter 12. Actually it doesn't say anything
about placement (ordering) of Ack.

So, formally the above follows the letter of law.

What did you have in mind when commenting that? Perhaps I missed documentation.

-- 
With Best Regards,
Andy Shevchenko





[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux