Hi deeee Ho peeps! On Thu, 2020-09-17 at 21:37 +0200, Krzysztof Kozlowski wrote: > Add common properties appearing in DTSes (clock-names, > clock-output-names) with the common values (actually used in DTSes) > to > fix dtbs_check warnings like: > > arch/arm64/boot/dts/freescale/imx8mq-librem5-r2.dt.yaml: > pmic@4b: 'clock-names', 'clock-output-names', do not match any of > the regexes: 'pinctrl-[0-9]+' > > Signed-off-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx> > > --- > > Changes since v1: > 1. Define the names, as used in existing DTS files. > --- > .../devicetree/bindings/mfd/rohm,bd71837-pmic.yaml | 6 > ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mfd/rohm,bd71837- > pmic.yaml b/Documentation/devicetree/bindings/mfd/rohm,bd71837- > pmic.yaml > index 65018a019e1d..3bfdd33702ad 100644 > --- a/Documentation/devicetree/bindings/mfd/rohm,bd71837-pmic.yaml > +++ b/Documentation/devicetree/bindings/mfd/rohm,bd71837-pmic.yaml > @@ -32,9 +32,15 @@ properties: > clocks: > maxItems: 1 > > + clock-names: > + const: osc I guess existing board dtses use "osc" then? Ok. > "#clock-cells": > const: 0 > > + clock-output-names: > + const: pmic_clk This is not a strong opinion but I feel that pmic_clk is a bit too generic name? I mean, what if there is a system with more than one PMICs? (I don't see such use-case with the BD718x7 though - but perhaps this can serve as a misleading example for other PMICs? For example with the ROHM BD96801 family there may be multiple PMICs in one system). Anyways - if Rob is happy with this then please go with it :) Acked-By: Matti Vaittinen <matti.vaittinen@xxxxxxxxxxxxxxxxx> * Thanks again for improving these bindings! I am constantly struggling with these x_x. Writing the bindings is probably hardest part of PMIC driver development -_-;
