On Tue, 15 Sep 2020 17:26:15 +0200 Marek Behún <marek.behun@xxxxxx> wrote: > + /* > + * Check whether LED has defined valid source for this trigger. > + * If yes, this trigger should be set as default trigger for LED. > + * This should use of_led_count_trigger_sources and > + * of_led_get_trigger_source functions. > + */ > + bool (*has_valid_source)(struct led_classdev *led_cdev); Hmm, the heartbeat and timer triggers do not need trigger sources. If we want to deprecate linux,default-trigger device tree property for these triggers also, this method should look to `function` DT property for heartbeat and timer triggers. In that case the name should be changed to something like of_is_valid_default_for, or something like that. Marek
