On Wed, Sep 9, 2020 at 11:37 PM Mauro Carvalho Chehab <mchehab+huawei@xxxxxxxxxx> wrote: > > Em Wed, 9 Sep 2020 14:15:59 -0600 > Rob Herring <robh+dt@xxxxxxxxxx> escreveu: > > > On Fri, Sep 4, 2020 at 4:23 AM Mauro Carvalho Chehab > > <mchehab+huawei@xxxxxxxxxx> wrote: > > > > > > Rename hikey970 to hi3670, in order to use a namespace > > > similar to hi3660 driver. > > > > > > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@xxxxxxxxxx> > > > --- > > > .../bindings/phy/phy-hi3670-usb3.txt | 4 +- > > > > Bindings should be a separate patch. > > Ok. I'll split it. > > > > > > drivers/phy/hisilicon/phy-hi3670-usb3.c | 98 +++++++++---------- > > > 2 files changed, 51 insertions(+), 51 deletions(-) > > > > > > diff --git a/Documentation/devicetree/bindings/phy/phy-hi3670-usb3.txt b/Documentation/devicetree/bindings/phy/phy-hi3670-usb3.txt > > > index 4cb02612ff23..2fb27cb8beaf 100644 > > > --- a/Documentation/devicetree/bindings/phy/phy-hi3670-usb3.txt > > > +++ b/Documentation/devicetree/bindings/phy/phy-hi3670-usb3.txt > > > @@ -2,7 +2,7 @@ Hisilicon Kirin970 usb PHY > > > ----------------------- > > > > > > Required properties: > > > -- compatible: should be "hisilicon,kirin970-usb-phy" > > > +- compatible: should be "hisilicon,hi3670-usb-phy" > > > > Unless this is unused, we can't just change it. It's an ABI. > > From upstream PoV, this binding is for a new driver that will be added > via this patchset. Please squash this change then. Rob
