On Tue, Sep 15, 2020 at 12:34 AM Vaittinen, Matti <Matti.Vaittinen@xxxxxxxxxxxxxxxxx> wrote: > > > Hello All, > > On Mon, 2020-09-14 at 16:44 -0600, Rob Herring wrote: > > On Fri, Sep 04, 2020 at 04:53:05PM +0200, Krzysztof Kozlowski wrote: > > > Add common properties appearing in DTSes (clock-names, > > > clock-output-names) to fix dtbs_check warnings like: > > > > > > arch/arm64/boot/dts/freescale/imx8mq-librem5-r2.dt.yaml: > > > pmic@4b: 'clock-names', 'clock-output-names', do not match any > > > of the regexes: 'pinctrl-[0-9]+' > > > > > > Signed-off-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx> > > > --- > > > .../devicetree/bindings/mfd/rohm,bd71837-pmic.yaml | 6 > > > ++++++ > > > 1 file changed, 6 insertions(+) > > > > > > diff --git a/Documentation/devicetree/bindings/mfd/rohm,bd71837- > > > pmic.yaml b/Documentation/devicetree/bindings/mfd/rohm,bd71837- > > > pmic.yaml > > > index 65018a019e1d..ecce0d5e3a95 100644 > > > --- a/Documentation/devicetree/bindings/mfd/rohm,bd71837-pmic.yaml > > > +++ b/Documentation/devicetree/bindings/mfd/rohm,bd71837-pmic.yaml > > > @@ -32,9 +32,15 @@ properties: > > > clocks: > > > maxItems: 1 > > > > > > + clock-names: > > > + maxItems: 1 > > > > Needs to define what the name is. > > Someone once told me that "naming is hard". > Do we have some good common convention for 32K oscillator input naming? No. > Or should it just be dropped? Yes, having a name for a single entry in *-names is kind of pointless IMO. > > > + > > > "#clock-cells": > > > const: 0 > > > > > > + clock-output-names: > > > + maxItems: 1 > > > > Ideally this one too, but we've been more flexible on it. > > Data-sheet for BD71837 uses pin name "C32k_OUT". So maybe this would be > good? What's in all the dts files? I'd go with that if there's any clear winner. If it's already a random free-for-all, then just leave it as-is. > > BD71838 uses "bd71828-32k-out" . so we could also go with this same > convention and use "bd71837-32k-out". Or - we could take a risk and > *assume* typical use case for this clk (as this is typically used with > i.MX8 I'd guess the 32k is used for RTC) and name it accordingly. It should be aligned with what the output is called, not what it is connected to. Rob
