On 06/12/2014 09:11 AM, Alban Bedel wrote: > Currently the Tamonten DTS define a fixed regulator for the 5V supply. > However this regulator is in fact on the base board. Fix this by > properly defining the regulators found on the base boards. > diff --git a/arch/arm/boot/dts/tegra20-medcom-wide.dts b/arch/arm/boot/dts/tegra20-medcom-wide.dts > + board_regulators { The name "board_regulators" encodes both type ("regulators") and identify ("board": the regulators on the board). DT node names are suposed to contain type but not identity information. The way this is done in other Tegra DTs is to have a regulators node in both the board and module DT files, and use different ranges of reg values for the board and module; e.g. 0..99 for module and 100.. for the board or similar. Other than that, this patch looks fine. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html