Quoting Stephen Boyd (2020-09-09 17:48:53) > This binding only describes the USB phy inside the USB3 + DP "combo" > phy. Add information for the DP phy and describe the sub-nodes that > represent the DP and USB3 phys that exist inside the combo wrapper. > Remove reg-names from required properties because it isn't required nor > used by the kernel driver. > > Cc: Jeykumar Sankaran <jsanka@xxxxxxxxxxxxxx> > Cc: Chandan Uddaraju <chandanu@xxxxxxxxxxxxxx> > Cc: Vara Reddy <varar@xxxxxxxxxxxxxx> > Cc: Tanmay Shah <tanmay@xxxxxxxxxxxxxx> > Cc: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx> > Cc: Manu Gautam <mgautam@xxxxxxxxxxxxxx> > Cc: Sandeep Maheswaram <sanm@xxxxxxxxxxxxxx> > Cc: Douglas Anderson <dianders@xxxxxxxxxxxx> > Cc: Sean Paul <seanpaul@xxxxxxxxxxxx> > Cc: Jonathan Marek <jonathan@xxxxxxxx> > Cc: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> > Cc: <devicetree@xxxxxxxxxxxxxxx> > Cc: Rob Herring <robh+dt@xxxxxxxxxx> > Cc: Rob Clark <robdclark@xxxxxxxxxxxx> > Signed-off-by: Stephen Boyd <swboyd@xxxxxxxxxxxx> > --- > .../bindings/phy/qcom,qmp-usb3-dp-phy.yaml | 91 +++++++++++++++++-- > 1 file changed, 81 insertions(+), 10 deletions(-) I noticed that I didn't document the new compatible string I'm using, qcom,sc7180-qmp-usb3-dp-phy, ugh. Should I copy the whole file over and make a new document for the new compatible string? That feels like the better solution vs. making this binding have min/max stuff where it fails to enforce the DP part of the phy. We can delete this binding once the kernel tree isn't using it, right? Rob H? > > diff --git a/Documentation/devicetree/bindings/phy/qcom,qmp-usb3-dp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qmp-usb3-dp-phy.yaml > index ef8ae9f73092..4154f5748d39 100644 > --- a/Documentation/devicetree/bindings/phy/qcom,qmp-usb3-dp-phy.yaml > +++ b/Documentation/devicetree/bindings/phy/qcom,qmp-usb3-dp-phy.yaml > @@ -17,13 +17,15 @@ properties: > - qcom,sdm845-qmp-usb3-phy > reg: