Hi Vinod, Thanks for the review comments. > -----Original Message----- > From: Vinod Koul <vkoul@xxxxxxxxxx> > Sent: Tuesday, September 8, 2020 10:36 AM > To: Swapnil Kashinath Jakhade <sjakhade@xxxxxxxxxxx> > Cc: kishon@xxxxxx; robh+dt@xxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; > devicetree@xxxxxxxxxxxxxxx; Milind Parab <mparab@xxxxxxxxxxx>; Yuti > Suresh Amonkar <yamonkar@xxxxxxxxxxx>; tomi.valkeinen@xxxxxx; > jsarha@xxxxxx; nsekhar@xxxxxx > Subject: Re: [PATCH v2 0/7] PHY: Prepare Cadence Torrent PHY driver to > support multilink configurations > > EXTERNAL MAIL > > > On 27-08-20, 15:28, Swapnil Jakhade wrote: > > Cadence Torrent PHY is a multiprotocol PHY supporting different > > multilink PHY configurations including DisplayPort, PCIe, USB, SGMII, > QSGMII etc. > > Existing Torrent PHY driver supports only DisplayPort. This patch > > series prepares Torrent PHY driver so that different multilink > > configurations can be supported. It also updates DT bindings > > accordingly. This doesn't affect ABI as Torrent PHY driver has never > > been functional, and therefore do not exist in any active use case. > > > > Support for different multilink configurations with register sequences > > for protocols above will be added in a separate patch series. > > Series looks good to me. > > > This patch series is dependent on PHY attributes patch series [1]. > > I did not see any obvious depends in the series, if it is not maybe good to > rebase and send without dependency > Sure. I will resend the series removing dependency. Thanks & regards, Swapnil > -- > ~Vinod
