The device tree property prefix describes the vendor, which in case of
S3FWRN5 chip is Samsung. Therefore the "s3fwrn5" prefix for "en-gpios"
and "fw-gpios" is not correct and should be deprecated. Introduce
properly named properties for these GPIOs and rename the fw-gpios" to
"wake-gpios" to better describe its purpose.
Signed-off-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
---
.../bindings/net/nfc/samsung,s3fwrn5.yaml | 24 ++++++++++++++-----
1 file changed, 18 insertions(+), 6 deletions(-)
diff --git a/Documentation/devicetree/bindings/net/nfc/samsung,s3fwrn5.yaml b/Documentation/devicetree/bindings/net/nfc/samsung,s3fwrn5.yaml
index 81e27cc85dd3..0889d3326f98 100644
--- a/Documentation/devicetree/bindings/net/nfc/samsung,s3fwrn5.yaml
+++ b/Documentation/devicetree/bindings/net/nfc/samsung,s3fwrn5.yaml
@@ -14,30 +14,42 @@ properties:
compatible:
const: samsung,s3fwrn5-i2c
+ en-gpios:
+ maxItems: 1
+ description:
+ Output GPIO pin used for enabling/disabling the chip
+
interrupts:
maxItems: 1
reg:
maxItems: 1
+ wake-gpios:
+ maxItems: 1
+ description:
+ Output GPIO pin used to enter firmware mode and sleep/wakeup control
+
s3fwrn5,en-gpios:
maxItems: 1
+ deprecated: true
description:
- Output GPIO pin used for enabling/disabling the chip
+ Use en-gpios
s3fwrn5,fw-gpios:
maxItems: 1
+ deprecated: true
description:
- Output GPIO pin used to enter firmware mode and sleep/wakeup control
+ Use wake-gpios
additionalProperties: false
required:
- compatible
+ - en-gpios
- interrupts
- reg
- - s3fwrn5,en-gpios
- - s3fwrn5,fw-gpios
+ - wake-gpios
examples:
- |
@@ -55,7 +67,7 @@ examples:
interrupt-parent = <&gpa1>;
interrupts = <3 IRQ_TYPE_LEVEL_HIGH>;
- s3fwrn5,en-gpios = <&gpf1 4 GPIO_ACTIVE_HIGH>;
- s3fwrn5,fw-gpios = <&gpj0 2 GPIO_ACTIVE_HIGH>;
+ en-gpios = <&gpf1 4 GPIO_ACTIVE_HIGH>;
+ wake-gpios = <&gpj0 2 GPIO_ACTIVE_HIGH>;
};
};
--
2.17.1
