Hello Vincent,
On Wed, Sep 02, 2020 at 02:11:54PM +0200, Vincent Whitchurch wrote:
> On Sat, Aug 15, 2020 at 09:50:32AM +0200, Uwe Kleine-König wrote:
> > On Fri, Aug 14, 2020 at 05:55:13PM +0200, Vincent Whitchurch wrote:
> > > +static const struct pwm_ops pwm_gpio_ops = {
> > > + .owner = THIS_MODULE,
> > > + .apply = pwm_gpio_apply,
> >
> > Usually a .get_state callback is nice. Does it make sense to do
> > something like:
> >
> > if (driver is up)
> > report current setting
> > else
> > val = gpio_get_value()
> > report(period=1, duty_cycle=val, enabled=val, polarity=NORMAL)
> >
> > ?
>
> I implemented get_state() but I didn't do the gpio_get_value() thing
> since the driver sets the gpio to a known value in probe().
This however is wrong, .probe() is not supposed to modify the output.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
Attachment:
signature.asc
Description: PGP signature
