Hi Rob, On Mon, Aug 24, 2020 at 05:04:58PM -0600, Rob Herring wrote: > On Mon, Aug 10, 2020 at 04:22:17PM +0100, Biju Das wrote: > > Document optional vcc-supply property that may be used as VCC source. > > > > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx> > > --- > > New patch Ref: Ref:https://patchwork.kernel.org/patch/11705819/ > > --- > > .../devicetree/bindings/display/bridge/lvds-codec.yaml | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml b/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml > > index 68951d56ebba..3248be31eceb 100644 > > --- a/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml > > +++ b/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml > > @@ -79,6 +79,9 @@ properties: > > The GPIO used to control the power down line of this device. > > maxItems: 1 > > > > + vcc-supply: > > + maxItems: 1 > > Probably should be 'power-supply' to align with the 'simple' panels. > That's also to signify there's only 1 supply. Using 'vcc' would > encourage adding 'vdd-supply', 'vddio-supply', etc. A second supply I'll > NAK because at that point it's not a simple bridge with no configuration > (it's arguably already there). Fully agreed. Do I get your Ab or Rb line with s/vcc/power/ and the commit message updated to dt-bindings: display: bridge: lvds-codec: Document power-supply property Document optional power-supply property that may be used to specify the regulator powering up the device. ? -- Regards, Laurent Pinchart
