On 27-08-20, 17:54, Reddy, MallikarjunaX wrote: > Hi Vinod, > Thanks for the review comments. > > On 8/25/2020 7:21 PM, Vinod Koul wrote: > > On 18-08-20, 15:00, Reddy, MallikarjunaX wrote: > > > > > > > + > > > > > + intel,chans: > > > > > + $ref: /schemas/types.yaml#/definitions/uint32-array > > > > > + description: > > > > > + The channels included on this port. Format is channel start > > > > > + number and how many channels on this port. > > > > Why does this need to be in DT? This all seems like it can be in the dma > > > > cells for each client. > > > (*ABC) > > > Yes. We need this. > > > for dma0(lgm-cdma) old SOC supports 16 channels and the new SOC supports 22 > > > channels. and the logical channel mapping for the peripherals also differ > > > b/w old and new SOCs. > > > > > > Because of this hardware limitation we are trying to configure the total > > > channels and port-channel mapping dynamically from device tree. > > > > > > based on port name we are trying to configure the default values for > > > different peripherals(ports). > > > Example: burst length is not same for all ports, so using port name to do > > > default configurations. > > Sorry that does not make sense to me, why not specify the values to be > > used here instead of defining your own name scheme! > OK. Agreed. I will remove port name from DT and only use intel,chans what is intel,chans, why not use dma-channels? -- ~Vinod
