Re: [linux-sunxi] [PATCH] ARM: dts: sun8i: r40: bananapi-m2-ultra: Fix dcdc1 regulator

[Jernej Škrabec <jernej.skrabec@xxxxxxxx>]

Dne ponedeljek, 24. avgust 2020 ob 22:54:01 CEST je Pablo Sebastián Greco 
napisal(a):
> On 24/8/20 16:36, Jernej Skrabec wrote:
> > DCDC1 regulator powers many different subsystems. While some of them can
> > work at 3.0 V, some of them can not. For example, VCC-HDMI can only work
> > between 3.24 V and 3.36 V. According to OS images provided by the board
> > manufacturer this regulator should be set to 3.3 V.
> > 
> > Set DCDC1 and DCDC1SW to 3.3 V in order to fix this.
> > 
> > Fixes: da7ac948fa93 ("ARM: dts: sun8i: Add board dts file for Banana Pi M2
> > 
> > 		      Ultra")
> > 
> > Signed-off-by: Jernej Skrabec <jernej.skrabec@xxxxxxxx>
> > ---
> > 
> >   arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts | 10 +++++-----
> >   1 file changed, 5 insertions(+), 5 deletions(-)
> > 
> > diff --git a/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts
> > b/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts index
> > 42d62d1ba1dc..ea15073f0c79 100644
> > --- a/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts
> > +++ b/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts
> > @@ -223,16 +223,16 @@ &reg_aldo3 {
> > 
> >   };
> >   
> >   &reg_dc1sw {
> > 
> > -	regulator-min-microvolt = <3000000>;
> > -	regulator-max-microvolt = <3000000>;
> > +	regulator-min-microvolt = <3300000>;
> > +	regulator-max-microvolt = <3300000>;
> > 
> >   	regulator-name = "vcc-gmac-phy";
> >   
> >   };
> >   
> >   &reg_dcdc1 {
> >   
> >   	regulator-always-on;
> > 
> > -	regulator-min-microvolt = <3000000>;
> > -	regulator-max-microvolt = <3000000>;
> > -	regulator-name = "vcc-3v0";
> > +	regulator-min-microvolt = <3300000>;
> > +	regulator-max-microvolt = <3300000>;
> > +	regulator-name = "vcc-3v3";
> > 
> >   };
> >   
> >   &reg_dcdc2 {
> 
> Should this be done also for the bananapi-m2-berry?, it is basically the
> same device
> sun8i-v40-bananapi-m2-berry.dts

I think so but I would rather not do that without testing and I don't have 
that board.

Best regards,
Jernej