On Sat, Aug 22, 2020 at 6:33 PM Paul Cercueil <paul@xxxxxxxxxxxxxxx> wrote: > +static const struct nv3052c_reg nv3052c_regs[] = { > + { 0xff, 0x30 }, > + { 0xff, 0x52 }, > + { 0xff, 0x01 }, > + { 0xe3, 0x00 }, > + { 0x40, 0x00 }, (...) Well that's pretty opaque :D I suppose no datasheet (why do vendors keep doing this to us...) In other kernel code I have referred to this as a "jam table", e.g. drivers/net/dsa/rtl8366rb.c. I didn't make this up, the name comes from Bunnie Huang's book on hacking the Xbox, and he says it is common hardware engineer lingo. https://www.iacr.org/workshops/ches/ches2002/presentations/Huang.pdf What about naming it nv3052c_jam_table[] or nv3052c_jam[]? Yours, Linus Walleij