Hi Prabhakar,
On Sun, Aug 16, 2020 at 9:33 PM Lad Prabhakar
<prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> wrote:
> Add support for the SPI NOR device used to boot up the system
> to the System on Module DT.
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
> Reviewed-by: Chris Paterson <Chris.Paterson2@xxxxxxxxxxx>
Thanks for your patch!
> --- a/arch/arm/boot/dts/r8a7742-iwg21m.dtsi
> +++ b/arch/arm/boot/dts/r8a7742-iwg21m.dtsi
> @@ -70,4 +80,28 @@
> groups = "mmc1_data4", "mmc1_ctrl";
> function = "mmc1";
> };
> +
> + qspi_pins: qspi {
> + groups = "qspi_ctrl", "qspi_data2";
> + function = "qspi";
> + };
> +};
> +
> +&qspi {
> + pinctrl-0 = <&qspi_pins>;
> + pinctrl-names = "default";
> +
> + status = "okay";
> +
> + /* WARNING - This device contains the bootloader. Handle with care. */
> + flash: flash@0 {
> + #address-cells = <1>;
> + #size-cells = <1>;
#{address,size}-cells are not needed, unless you list legacy partitions
(i.e. partitions not contained in a "partitions" container).
> + compatible = "sst,sst25vf016b", "jedec,spi-nor";
> + reg = <0>;
> + spi-max-frequency = <50000000>;
> + m25p,fast-read;
> + spi-cpol;
> + spi-cpha;
Perhaps you want to add the partition layout, too?
> + };
> };
With the above fixed/clarified:
Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
