On Thu, Aug 20, 2020 at 4:31 AM Abel Vesa <abel.vesa@xxxxxxx> wrote: .... > > > +extern const struct imx_blk_ctrl_dev_data imx8mp_audio_blk_ctrl_dev_data __initconst; > > > +extern const struct imx_blk_ctrl_dev_data imx8mp_media_blk_ctrl_dev_data __initconst; > > > +extern const struct imx_blk_ctrl_dev_data imx8mp_hdmi_blk_ctrl_dev_data __initconst; > > > + > > > > If no special reasons, i may prefer to put those data in either > > clk-blk-ctrl.c or separate clk-blk-ctrl-data.c > > because there seems to be no code level dependency on the CCM > > driver(clk-imx8mq.c) for clk_blk_ctrl drivers. > > Then we can save those extern variables. > > > > The rationale here is to have the SoC specific definitions in the SoC specific > clock provider driver. Otherwise with every new SoC that will use the blk_ctl > IPs we will increase the size of clk-blk-ctrl driver. Plus the kernel names of > the clocks used by each blk_ctl IP as parents are also defined in the SoC > specific clock provider driver. > > I'll find a way, though, to move those so that they would not be shared between > all the clock drivers that needs a blk_ctl implementation. > Please refer to pinctrl-imx.c to see if we can do similar things for blk-ctrl. Regards Aisheng > > Regards > > Aisheng > > > > > +#endif > > > + > > > -- > > > 2.7.4 > > >
