Hi Jakub, These 2 function are used in the same file only. I'll fix warnings by making 2 functions 'static' in v3. Landen On Tue, 2020-08-18 at 23:23 +0800, Jakub Kicinski wrote: [snip] > Please fix these W=1 warnings: > > ../drivers/net/dsa/mt7530.c:1976:1: warning: no previous prototype for ‘mt7531_sgmii_link_up_force’ [-Wmissing-prototypes] > 1976 | mt7531_sgmii_link_up_force(struct dsa_switch *ds, int port, > | ^~~~~~~~~~~~~~~~~~~~~~~~~~ > ../drivers/net/dsa/mt7530.c:2081:6: warning: no previous prototype for ‘mt7531_sgmii_restart_an’ [-Wmissing-prototypes] > 2081 | void mt7531_sgmii_restart_an(struct dsa_switch *ds, int port) > | ^~~~~~~~~~~~~~~~~~~~~~~ > ../drivers/net/dsa/mt7530.c:1976:1: warning: symbol 'mt7531_sgmii_link_up_force' was not declared. Should it be static? > ../drivers/net/dsa/mt7530.c:2081:6: warning: symbol 'mt7531_sgmii_restart_an' was not declared. Should it be static?
