On Tue, 18 Aug 2020 15:14:10 +0800 Landen Chao wrote: > Add new support for MT7531: > > MT7531 is the next generation of MT7530. It is also a 7-ports switch with > 5 giga embedded phys, 2 cpu ports, and the same MAC logic of MT7530. Cpu > port 6 only supports SGMII interface. Cpu port 5 supports either RGMII > or SGMII in different HW sku. Due to SGMII interface support, pll, and > pad setting are different from MT7530. This patch adds different initial > setting, and SGMII phylink handlers of MT7531. > > MT7531 SGMII interface can be configured in following mode: > - 'SGMII AN mode' with in-band negotiation capability > which is compatible with PHY_INTERFACE_MODE_SGMII. > - 'SGMII force mode' without in-bnad negotiation > which is compatible with 10B/8B encoding of > PHY_INTERFACE_MODE_1000BASEX with fixed full-duplex and fixed pause. > - 2.5 times faster clocked 'SGMII force mode' without in-bnad negotiation > which is compatible with 10B/8B encoding of > PHY_INTERFACE_MODE_2500BASEX with fixed full-duplex and fixed pause. > > Signed-off-by: Landen Chao <landen.chao@xxxxxxxxxxxx> > Signed-off-by: Sean Wang <sean.wang@xxxxxxxxxxxx> Please fix these W=1 warnings: ../drivers/net/dsa/mt7530.c:1976:1: warning: no previous prototype for ‘mt7531_sgmii_link_up_force’ [-Wmissing-prototypes] 1976 | mt7531_sgmii_link_up_force(struct dsa_switch *ds, int port, | ^~~~~~~~~~~~~~~~~~~~~~~~~~ ../drivers/net/dsa/mt7530.c:2081:6: warning: no previous prototype for ‘mt7531_sgmii_restart_an’ [-Wmissing-prototypes] 2081 | void mt7531_sgmii_restart_an(struct dsa_switch *ds, int port) | ^~~~~~~~~~~~~~~~~~~~~~~ ../drivers/net/dsa/mt7530.c:1976:1: warning: symbol 'mt7531_sgmii_link_up_force' was not declared. Should it be static? ../drivers/net/dsa/mt7530.c:2081:6: warning: symbol 'mt7531_sgmii_restart_an' was not declared. Should it be static?